-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onyx: add support for eink devices #5073
Comments
Hi, |
Uh, ok, try this build instead: https://www.dropbox.com/s/p5c0kbi8gqz3pky/koreader-android-arm-linux-androideabi-debug-v2019.04-101-gefe34b6f_2019-06-03.apk?dl=0, it has more debug statements. You need to delete the old apk first and then install the new one.
Also, please check that KOReader has the following permission granted ("change/modify system settings) It should be enabled by default since the installation unless you went to settings and disable the permission yourself. |
Here it is. |
No errors on your log, that's good! FWIW, there is a service that logs just after every frontlight change:
Waiting for an onyx developer 🙂 |
Hi again, I have a very interesting observation. Today Onyx released firmware update 2.1.2 so I upgraded. At some point I noticed that KOreader doesn't have flickering problem without A2 mode (in menu and during highlighting) but after reboot the problem reappeared. After I played a bit with it again, I noticed that if I first open native reading app NeoReader 3.0 and then KOreader, the problem in KOreader disappear :) Nice. |
@elc00l, if you, as a customer, want to contact Onyx developers and inform about the problem, you're free to do so. I think they can fix the issues with this app or, at least, provide us a guide to work with these devices. |
Here a video showing the flickering for Onyx Boox Darwin 6 device ( When setting in the e-ink options to refresh every page, then each page is at least readable, but still it is flickering and the menus are not readable at all. The front light issue is there for this device, too (although I don't need that). |
That vaguely looks like broke-ass reagl handling. Is that one of those devices trying to use reagl wfm modes? |
@mahlzahn: I couldn't call this flickering. See OP videos. The video you uploaded shows that onyx are not compatible with waveform modes used by Tolinos (probably the only one that works is the basic GC16 that does the fullscreen update, which is used on the test utility). In short: stay with A2 or get another application until somebody fixes it. If you want to fix it yourself please look at how was done for other devices. It requires a bit of RE, basic command line knowledge and plenty of time for trial/error. |
Okay, thanks for your answers! Unfortunately the original videos in the first thread of this issue are not available anymore and I couldn't compare with my observation. Will stay with A2 then for now. |
Onyx updated its firmwares for many devices recently. After the upadtion, I found that the screen doesn't flicker when A2 mode is off. However, when running "test ink", there isn't the flashing black though it still reads "pass" when running test #3. |
Anyway guys, if you want we have a little space here https://discord.gg/MJsjcKJ about app dev on Onyx Boox devices. So if you are an Onyx owner and app dev join us. |
pinging @wangsuicheng. Maybe onyx can help with this issue ¿? Or send a device 😄 |
I think Onyx is too worried about IP loss/theft. Assistance with development/bug fixing/triaging was offered by the community in their forums, but was declined. Boox would rather let their devices become doorstops then get things moving more quickly on the software front. Actually I'm not quite sure if Boox was even informed about the offer of community support. Maybe Onyx (as the people behind the software, as far as I know) declined, but never consulted Boox. |
Screen still flashes when using menu and highlighting text. :) |
Sure. It will depend on the update frequency. If it is set to 1, each press on the screen (menu opening, highlighting or any other operation) will make it flash. If it is set to 20, it will not occur until you press 20. |
I've set mine at 0 and still get flashes. Can you please paste your app config and fw version? :) |
Sorry, I like totally "clean" screens, so I have the screen refresh set to 1. But if I set it to 0 or 100 the screen doesn't flash. The firmware version is 2020-04-22_14-50_2.3_7e954fc. And I have installed the latest nigthly version of KOReader. |
Thanks @Cellaris and @szebrowski for the heads up!
It still sounds a little bit broken to me. In the best case scenario I would want to disable system optimizations and perform any screen refreshes in the program. I'm sure this can be done using Onyx's SDK, but still waiting for someone with a device willing to try. Will leave the ticket opened until then. |
I can try it if it doesn't brick my device ;) edit: also I think that adb supports network debugging |
I have a bit of trouble understanding the current problems with the Onyx devices. I got an Onyx Boox Note Pro and both with firmwares 2.2.2 and 2.3 the koreader versions of two weeks back work well. I like that when you try to change the frontlight, it says that the system handles it. I put the frontlight to the Navigation Ball and it works like expected. I only got root access, not a good SELinux context (via the dirtyCow exploit,) but that should be enough for debugging via adb. |
Probably no different than sketched in the OP. There's some stuff here meant for Tolinos: Pinging @pazos |
In theory they should work exactly like any non-supported devices (HiSense e-ink phones, for instance). That's it: anything that has an android API should work and things that don't have one shouldn't (I'm talking about non default frontlight settings and E-ink updates). |
@pazos That was my experience, too. :) |
@Markismus: device dpi is reported by the NDK in https://github.com/koreader/koreader/blob/master/frontend/device/android/device.lua#L80. You can override it in settings-> screen -> screen resolution. Reported values were tested against a myriad of android emulators (you have a list in https://material.io/resources/devices/, wasn't tested in watches - yet 😄. Values are reported correctly everywhere, which is odd because NDK is pretty broken. Higher resolution devices, flagged as xxxhdpi, display menus a big bigger than I like but things are much worst in 10"+ screen even on lower densities. But there's nothing android specific here. I would expect the same behaviour on bigger linux devices like the Remarkable. |
I'm going to close this issue as won't fix. Feel free to submit patches. Both frontlight and epd should be abstracted in the near future (with koreader/android-luajit-launcher#239), so it is a matter of people writting the right implementation for their device, but there's no difference between onyx or any other android device vendor. Thanks for the feedback! |
I'm still having e-ink flashes. I don't really know why. It starts randomly. I've tried every configuration combination but no success. When I rebooted, it worked as it should but now I suffer from the flashes and nothing helps. |
Could you post a video somewhere? The one in the first post is broken. The only "flashes" I know of are when "Regal" mode is set, but I believe it's how it's supposed to work. I use either "A2" or "Normal" mode and it works decently well, although it's slow ;/ |
Some known issues:
frontlight seems to use a custom interface, not common android interface:
screen is flickering if A2 is not enabled:
Currently no dev has one of these devices, so we are waiting for help..
The text was updated successfully, but these errors were encountered: