Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging out from sync server does not update the menu text #5224

Closed
pbienst opened this issue Aug 18, 2019 · 0 comments · Fixed by #5278
Closed

logging out from sync server does not update the menu text #5224

pbienst opened this issue Aug 18, 2019 · 0 comments · Fixed by #5278
Labels
bug UX
Milestone
2019.09

Comments

@pbienst
Copy link

pbienst commented Aug 18, 2019

  • KOReader version: 2019.08
  • Device: Android + Kobo

When logged in to the sync server, pressing 'logout' does indeed seem to log you out, but the menu text is not updated to 'login'.

It does act as 'login' though, since pressing that menu entry again does indeed allow you to login.
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 28, 2019
@Frenzie
[fix, UX] Update kosync login/logout text
4408ea9 
As a side effect of <koreader#4189> some menus have to manually trigger updates.

I'm not overly enthused with this solution but I couldn't think of anything better right now.

Fixes <koreader#5224>.
@Frenzie Frenzie mentioned this issue Aug 28, 2019
Merged
@Frenzie Frenzie added this to the 2019.09 milestone Aug 28, 2019
Frenzie added a commit that referenced this issue Aug 29, 2019
@Frenzie
[fix, UX] Update kosync login/logout text (#5278)
6979e08 
As a side effect of <#4189> some menus have to manually trigger updates.

I'm not overly enthused with this solution but I couldn't think of anything better right now.

Fixes <#5224>.
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
@Frenzie @mwoz123
[fix, UX] Update kosync login/logout text (koreader#5278)
c9587d4 
As a side effect of <koreader#4189> some menus have to manually trigger updates.

I'm not overly enthused with this solution but I couldn't think of anything better right now.

Fixes <koreader#5224>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug UX
Projects
None yet
Milestone
2019.09
Development

Successfully merging a pull request may close this issue.

[fix, UX] Update kosync login/logout text Frenzie/koreader
3 participants
@NiLuJe @Frenzie @pbienst