Crash during notes export to Evernote

[abdoulayeYATERA]

• KOReader version: v2019.11
• Device: Kobo Format

Issue

Crash during notes export to Evernote.
Need your help guys !!! (girls also ^ ^)
Thank's

Steps to reproduce

1 - Log with your Evernot account
2 - Export notes to Evernote

crash.log (if applicable)

[abdoulayeYATERA]

Hmm strange Github behavior...., click on the image to see the crash log in the right orientation...

[NiLuJe]

xref: https://www.mobileread.com/forums/showthread.php?p=3913268#post3913268

Regression since #5431

[hgrain86]

also on kobo aura one koreader v2019.11

[arooni]

also on pixel xl and fire 10 tablet ; all using 2019.11

[LucenaWoods]

Also on PW2: Crashes every time I try to export all notes to local html file.

[roger64]

also on Kindle PW3. Koreader crashes and I am back to Kindle.

The crash happens exactly when I try to identify myself and to write the password.

[mustafa-001]

It was introduced in https://github.com/koreader/koreader/pull/5440/files/7e7feb760dd90abef9f4600a140ad5fc46088f11#diff-d2ad3c080f3901bd500b297d33ce25b1

koreader/plugins/evernote.koplugin/clip.lua

Line 290 in 55f3575

self:parseHighlight(stored.highlight, stored.bookmarks, clippings.title)

clippings.title resolves to clippings.["title"] not clippings[title] as it should be.

To my defence it was suggested at PR review and I simply clicked "commit suggestion" :)

[Frenzie]

That must've been a reflex because elsewhere that was full of (the equivalent of) clippings["title"], my bad. But don't just click commit suggestion. ;-)

[2016201256]

It was introduced in https://github.com/koreader/koreader/pull/5440/files/7e7feb760dd90abef9f4600a140ad5fc46088f11#diff-d2ad3c080f3901bd500b297d33ce25b1

koreader/plugins/evernote.koplugin/clip.lua

Line 290 in 55f3575

self:parseHighlight(stored.highlight, stored.bookmarks, clippings.title)

clippings.title resolves to clippings.["title"] not clippings[title] as it should be.
To my defence it was suggested at PR review and I simply clicked "commit suggestion" :)

Thanks for your contribution! I would like to know how to fix this bug by myself? Or I have to wait for the next updated APK?

[Frenzie]

You can check for updates on the development channel (under hamburger menu → update) and download the latest nightly that way, or manually go to http://build.koreader.rocks/download/nightly/ and grab it there.

[abdoulayeYATERA]

Got it ! Thank you guys !
Keep up the good work !