Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various string issues #5712

Closed
Frenzie opened this issue Dec 31, 2019 · 0 comments · Fixed by #5719
Closed

Various string issues #5712

Frenzie opened this issue Dec 31, 2019 · 0 comments · Fixed by #5719
Labels
Milestone

Comments

@Frenzie
Copy link
Member

Frenzie commented Dec 31, 2019

  • KOReader version: current master
  • Device: all

Issue

Identified thanks to Weblate.

Should use util.template.

local entry = _("Title: ") .. (self.data[i][self.title] or "-") .. "\n \n" ..
_("Author(s):") .. " " .. (self.data[i][self.authors2] or "-") .. "\n \n" ..
_("Tags:") .. " " .. (self.data[i][self.tags2] or "-") .. "\n \n" ..
_("Series:") .. " " .. (self.data[i][self.series] or "-")

text = string.format("%s %s \n %s",
_("SSH port: "), self.SSH_port,
Device.retrieveNetworkInfo and Device:retrieveNetworkInfo() or _("Could not retrieve network info.")),

current_state = _("(Classic mode) ") .. current_state

Trailing space

text = _("Series "),

(Not sure if this one is actually an issue, so I'll leave it be.)

notemarks = _("Note: "),

@Frenzie Frenzie added this to the 2020.01 milestone Dec 31, 2019
@Frenzie Frenzie added the bug label Dec 31, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Jan 1, 2020
Frenzie added a commit that referenced this issue Jan 1, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant