Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong file count in folders #5843

Closed
BrainDamage opened this issue Feb 11, 2020 · 1 comment · Fixed by #5846
Closed

wrong file count in folders #5843

BrainDamage opened this issue Feb 11, 2020 · 1 comment · Fixed by #5846
Milestone

Comments

@BrainDamage
Copy link

  • KOReader version:V2020.01-28-ga2eea88d_2020-02-10
  • Device: Kobo Aura H2O2

Issue

File count in folders is inconsistent and/or wrong, there's multiple issues here

Steps to reproduce

first bug:
create an empty directory
enable "show hidden files" in the file manager
the empty directory will show 2 elements, and if new files are dragged in, the offset will be always shifted by 2
I suspect it's counting the '.' current directory and '..' parent path

second issue:
create an empty directory
set "show hidden files" to disabled ( although it's irrelevant since koreader hides .sdr folders regardless )
drag inside a new ebook, never read, never cached
verify item count, it should be 1 if "show hidden files" is disabled, 3 if enabled
open the ebook so it generates a .sdr directory even if it's hidden by the ui
verify item count of the directory, it has been increased by 1
delete the .sdr directory and the count goes back by 1

while it's not technically wrong because the content exists, the count is inconsistent with the displayed elements, making it confusing

@Frenzie Frenzie added this to the 2020.02 milestone Feb 11, 2020
Frenzie added a commit to Frenzie/koreader that referenced this issue Feb 11, 2020
Frenzie added a commit that referenced this issue Feb 11, 2020
@BrainDamage
Copy link
Author

second issue still present as of commit de15ab3, but now only when "show hidden files" is disabled

to reproduce:

set "show hidden files" to disabled
create an empty directory
drag inside a new ebook, never read, never cached
verify item count, it should be 1
open the ebook so it generates a .sdr directory even if it's hidden by the ui
verify item count of the directory, it is now 2
delete the .sdr directory and the count goes back to 1

yparitcher added a commit to yparitcher/koreader that referenced this issue Feb 13, 2020
Frenzie pushed a commit that referenced this issue Feb 13, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants