Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate of CREngine #5946

Closed
mergen3107 opened this issue Mar 13, 2020 · 2 comments · Fixed by #5947
Closed

Duplicate of CREngine #5946

mergen3107 opened this issue Mar 13, 2020 · 2 comments · Fixed by #5947
Assignees
@Frenzie
Labels
bug
Milestone
2020.04

Comments

@mergen3107
Copy link
Contributor

  • KOReader version: v2020.03.01
  • Device: Kindle PW3 (5.9.7)

Issue

FileManager_2020-Mar-11_044714
Duplicate of CREngine in the FM 'Open with' dialog.

Steps to reproduce

Open KOReader
Go to File Manager
Find a file (in this case I used a book in fb2.zip format)
Tap and hold
Select 'Open with'
'Cool Reader Engine' is shown twice. A duplicate is shown as 'selected', but it cannot be deselected or selected. If I tap on it, the previous choice remains there (e.i. if it was on MuPDF, it will still use MuPDF to open the file).

crash.log

is not applicable. since KOReader does not crash with this dialog.
@mergen3107 mergen3107 changed the title Duplicate of CREngine Duplicate of CREngine label:bug Mar 13, 2020
@mergen3107 mergen3107 changed the title Duplicate of CREngine label:bug Duplicate of CREngine Mar 13, 2020
@NiLuJe
Copy link
Member

NiLuJe commented Mar 13, 2020 •
edited

Hmm, it's getting a DocumentRegistry from both fb2 and zip, maybe?

@Frenzie Frenzie added the bug label Mar 13, 2020
@Frenzie
Copy link
Member

Frenzie commented Mar 13, 2020

Btw, expected crash in debug mode:

03/13/20-20:53:44 DEBUG setDirty via a func from widget table: 0x7f6288943b20
./luajit: frontend/ui/widget/radiobuttontable.lua:86: RadioButtonGroup: multiple checked RadioButtons
stack traceback:

@Frenzie Frenzie self-assigned this Mar 13, 2020
@Frenzie Frenzie added this to the 2020.04 milestone Mar 13, 2020
Frenzie added a commit to Frenzie/koreader that referenced this issue Mar 13, 2020
@Frenzie
[fix] DocumentRegistry: only add provider once
bc8c58f 
Fixes <koreader#5946>.
@Frenzie Frenzie mentioned this issue Mar 13, 2020
Merged
Frenzie added a commit that referenced this issue Mar 13, 2020
@Frenzie
[fix] DocumentRegistry: only add provider once (#5947)
c2aac0f 
Fixes <#5946>.
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
@Frenzie @mwoz123
[fix] DocumentRegistry: only add provider once (koreader#5947)
8aa7c42 
Fixes <koreader#5946>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frenzie Frenzie

Labels
bug
Projects
None yet
Milestone
2020.04
Development

Successfully merging a pull request may close this issue.

[fix] DocumentRegistry: only add provider once Frenzie/koreader
3 participants
@NiLuJe @Frenzie @mergen3107