-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallabag removes not completed/not read, previously downloaded files. #6119
Comments
I've noticed this issue myself. PS: Not really the same issue; but is there any way to add articles to wallabag if you're not actively connected to wifi? Queue them up for later? |
No, that's still waiting for someone to implement it. |
Workaround that worked for me was to increate download limit (in "settings" -> "configure Wallagag client" ) from default 30 to 100 (I've ~95 articles). The first sync was very long ~5min but next time was much quicker.
Great idea. If it's not already requestested I think we should extract it to new FR;) |
It's not in any issue, but I explicitly stated it as the obvious next step when I added "add to wallabag." ;-) |
What if I already have hundreds of articles in wallabag ? Wouldn’t I need to set the number on the client to 1000 to make this work for me ? Not sure I want to overload my poor kindle |
Now that I've taken the time to think about it, I'm not entirely convinced this is an issue. You're telling the plugin you only want 30 articles. But I can see the point that you'd want to keep the as of yet unread ones. Additionally, that 30 is a default Wallabag behavior. In that sense it may be intended slightly differently. |
Issue
By default wallabag downloads last 30 articles.
When:
Synchronize remotely deleted files
is checkedon after next sync in Wallabag Koreader dir you will have 30 articles (20 new and 10 already downloaded) and Wallabag plugin will remove 20 previously downloaded not read articles from koreader device.
This seems to be caused by this lines:
https://github.com/koreader/koreader/blob/master/plugins/wallabag.koplugin/main.lua#L637-L639
remote_article_ids
is the list of article ids from current downloadIn this case not being on the current download list doesn't mean it was deleted from server..
Steps to reproduce
Add 30 articles to wallabag server, "download" (sync) them from koreader. Don't read them.
Add 20 more articles to wallabag server. "download" sync them with Koreader. 20 previously downloaded, not read are gone.
The text was updated successfully, but these errors were encountered: