Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation ignored by "Highlight trimmers" #6473

Closed
adrien-mogenet opened this issue Aug 4, 2020 · 2 comments
Closed

Punctuation ignored by "Highlight trimmers" #6473

adrien-mogenet opened this issue Aug 4, 2020 · 2 comments

Comments

@adrien-mogenet
Copy link

  • KOReader version: master
  • Device: all

Issue

When highlighting content and adjusting the end of the highlighted part using the last two arrows (end <-, end ->), they ignore the punctuation.

For instance:

First sentence. Second sentence. Third sentence.

If I highlight "Second" and then extend to "sentence", I would expect

Second sentence.

to be highlighted. Instead, it will extend to "sentence" only, ignoring the final dot. It's a bit annoying especially when exporting the notes (you can't help but wonder if you highlighted properly)

@poire-z
Copy link
Contributor

poire-z commented Aug 4, 2020

See #6217 (comment) .

When you tap on the highlight to get the editing dialog (#4582), tap will extend the selection by word, but long-press on the arrows allows you to move it by char and include the punctuation:
image

@adrien-mogenet
Copy link
Author

Gotcha, I was actually reading the source code to make the change myself and was getting close to that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants