Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language string 1902 (key and secret key for Goodreads) #6539

Closed
leschek opened this issue Aug 22, 2020 · 2 comments · Fixed by #6542
Closed

Update language string 1902 (key and secret key for Goodreads) #6539

leschek opened this issue Aug 22, 2020 · 2 comments · Fixed by #6542
Assignees
Labels
Milestone

Comments

@leschek
Copy link

leschek commented Aug 22, 2020

I think this language string (string 1902) is not correct anymore:
`How to generate a key and a secret key:

  1. Go to https://www.goodreads.com/user/sign_up and create an account
  2. Register for a development key on the following page: https://www.goodreads.com/user/sign_in?rd=true
  3. Your key and secret key will now be available on https://www.goodreads.com/api/key
  4. Enter your generated key and your secret key in the settings dialog (Login to Goodreads window)
    `

it works this way (at least for me):

  1. Go to https://www.goodreads.com/user/sign_up and create an account
  2. Fill up the form and generate your key and secret key on page: https://www.goodreads.com/api/key
  3. Enter your generated key and your secret key in the settings dialog (Login to Goodreads window)
@Frenzie
Copy link
Member

Frenzie commented Aug 22, 2020

Fill up the form and generate your key and secret key on page: https://www.goodreads.com/api/key

That URL actually says page not found. Do you know what it should be?

@leschek
Copy link
Author

leschek commented Aug 22, 2020

Well, I sign up to Goodreads only because I did translation of KOReader, so I'm not power user.
But it seems it's working when you go there via API link at the bottom of user's profile: https://www.goodreads.com/api
Sorry I didn't realize it before I posted this issue.

@Frenzie Frenzie added this to the 2020.09 milestone Aug 22, 2020
@Frenzie Frenzie added the i18n label Aug 22, 2020
@Frenzie Frenzie self-assigned this Aug 22, 2020
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 22, 2020
Frenzie added a commit that referenced this issue Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants