Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opdsbrowser - missing acquisition relation types (at least one more needed) #940

Closed
evgsh opened this issue Sep 30, 2014 · 3 comments
Closed

Comments

@evgsh
Copy link
Contributor

evgsh commented Sep 30, 2014

Already handles - "http://opds-spec.org/acquisition": A generic relation that indicates that the complete representation of the content Resource may be retrieved.
please also consider adding :
"http://opds-spec.org/acquisition/open-access": Indicates that the complete representation of the Resource can be retrieved without any requirement, which includes payment and registration.

Thanks you are the best :)

@evgsh
Copy link
Contributor Author

evgsh commented Sep 30, 2014

example link that is completely ignored:
link href="/b/217009/epub" rel="http://opds-spec.org/acquisition/open-access" type="application/epub+zip"

@evgsh
Copy link
Contributor Author

evgsh commented Sep 30, 2014

I've tried something like adding:

#43 acquisition_rel_open_access = "http://opds-spec.org/acquisition/open-access",
https://github.com/koreader/koreader/blob/master/frontend/ui/widget/opdsbrowser.lua#L43
...
#334 or if link.rel == self.acquisition_rel_open_access then
https://github.com/koreader/koreader/blob/master/frontend/ui/widget/opdsbrowser.lua#L334

looks a little artificial though..

@chrox
Copy link
Member

chrox commented Oct 3, 2014

The patch @Eureka posted should work. Could you send a pull request since @Eureka is not on Github, of course we need to get his permission to use that patch.

evgsh pushed a commit to evgsh/koreader that referenced this issue Oct 3, 2014
chrox added a commit that referenced this issue Oct 3, 2014
opds / Added acquisition relation types , fixes issue #940
@evgsh evgsh closed this as completed Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants