ReaderFooter: separate ToggleFooterMode from TapFooter #10361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiLuJe
approved these changes
Apr 30, 2023
the footer can be toggled by gestures and menu, and should only be locked or skim in flipping mode when the footer is tapped also allow toggling when only displaying the progress bar rename to TapFooter to show it is not an event Fixes: koreader#10355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the footer can be toggled by gestures and menu, and should only be locked (or skim in flipping mode) when the footer is tapped
also allow toggling when only displaying the progress bar
Fixes: #10355
This change is