Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File popup dialog buttons #10537

Merged
merged 7 commits into from Jun 8, 2023
Merged

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Jun 4, 2023

(1) New file popup dialog buttons:
-History: Add/remove to/from favorites
-History, Favorites: Show folder

(2) Favorites: new left titlebar menu with
Add/remove current book to/from favorites
Add a book to favorites - choose a book via PathChooser
Sort favorites - previously was in the file popup dialog

Closes #10343. @ichnilatis-gr

File browser
01

History
02

Favorites
03

Favorites (called from FM)
04

Favorites (called from Reader)
05


This change is Reviewable

@poire-z
Copy link
Contributor

poire-z commented Jun 4, 2023

I'm fine with the dialogs layouts.
Not paying much attention to the code, not a fan of favorites :)
Just mentionning that ReadCollection is rather unoptimized (#6054 (comment)), as it reread the full collection.lua each time we call one of its functions. From a quick look at this PR, it looks like it will be done once each time we display such a dialog, so it's bearable - if it is really just once.

@hius07
Copy link
Member Author

hius07 commented Jun 4, 2023

Yes, and when editing Favorites it flushes on every single operation (add, remove, sort). Must be fixed (some day).

@Frenzie Frenzie added this to the 2023.06 milestone Jun 4, 2023
@hius07 hius07 merged commit 01e6593 into koreader:master Jun 8, 2023
3 checks passed
@hius07 hius07 deleted the popup-dialog-buttons branch June 8, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: "Add to favorites" in History view / Add "Go to folder" option
3 participants