Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks: filter by highlight style #10549

Merged
merged 2 commits into from Jun 8, 2023

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Jun 6, 2023

Fetching drawers from the highlights turned out to be rather fast, so I think this can be implemented.

Closes #10189. Closes #10543. @benasocj @Atrate

1

2


This change is Reviewable

@Frenzie Frenzie added this to the 2023.06 milestone Jun 6, 2023
Copy link
Contributor

@poire-z poire-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not really reviewed, trusting you.)

@hius07 hius07 merged commit 23feb0c into koreader:master Jun 8, 2023
3 checks passed
@hius07 hius07 deleted the bookmark-highlight-style branch June 8, 2023 05:28
@Codoscope
Copy link

@hius07 I can see on your screenshots that your Bookmarks page shows multiple lines for every highlight. On my device with the lastest version of Koreader, it only shows one line for each, be it on ePub or PDF. How do you manage to print multiple lines? Has it been removed on newer versions? Is it possible to show each highlight in its entirety?

@hius07
Copy link
Member Author

hius07 commented Jan 21, 2024

Top menu - first tab - Settings - Bookmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants