[ota]: deprecation check & notice #10639
Conversation
|
This seems fine to me. |
|
Yeah, I can't really think of a way to handle this retro-actively anyway :/. |
|
Yes, I think that's sensible. |
pazos
changed the title
frontend/ui/otamanager.lua
Outdated
| @@ -227,6 +229,10 @@ function OTAManager:fetchAndProcessUpdate() | |||
| UIManager:show(InfoMessage:new{ | |||
| text = _("KOReader is up to date."), | |||
| }) | |||
| elseif ota_version == -1 then | |||
| UIManager:show(InfoMessage:new{ | |||
| text = T(_("Device no longer supported.\n\nPlease check %1."), "https://github.com/koreader/koreader/wiki/deprecated-devices") | |||
There was a problem hiding this comment.
Always bothering to leave a period . at the end of the URL, people typing it with the period will get a 404.
| @@ -227,6 +229,10 @@ function OTAManager:fetchAndProcessUpdate() | |||
| UIManager:show(InfoMessage:new{ | |||
| text = _("KOReader is up to date."), | |||
| }) | |||
| elseif ota_version == -1 then | |||
| UIManager:show(InfoMessage:new{ | |||
| text = T(_("Device no longer supported.\n\nPlease check %1"), "https://github.com/koreader/koreader/wiki/deprecated-devices") | |||
There was a problem hiding this comment.
I'm not sure if this change to use template is necessarily a good idea, although of course something like the Chinese documentation on the wiki comes with its own set of issues (mainly that I have no idea how out of date it might be :-) ).
There was a problem hiding this comment.
Anyway, good to go in my book, please merge today or tomorrow so that there'll be some translations by Saturday.
Sorry for only thinking of this after the point release, but we can freeze The otamanager getotamodel will have to check that the android device is >= the sdk version. (This is similar to our kindle check). We would only need to change 2 lines in nightswatcher https://github.com/koreader/koreader-misc/blob/d39aa7b834174a99c8821898424bfff1b95607ce/nightswatcher/nightswatcher.py#L192 Therefore any old version will only update using the frozen file until 06.1, and only then will it have code to recognize there are new updates for newer devices. This would require us to keep 06.1 for android around for a while. (Fdroid is aware of sdk versions so we shouldnt have to do anything for it) This may be too much complexity for little gain, but just putting it out there. Epecialy since i missed the release boat :) |
|
We can also just edit the link_format string which requires no dynamic code, but has the downside of dragging appimage along for no good reason. Also this would clutter the ota server with an extra ~10 small files for each android deprecation |
Poor man implementation since we cannot fullfit #10610 (comment)
So instead, we merge something like this a few days/weeks before real deprecation and warn users with EOL devices that the source of trust is in https://github.com/koreader/koreader/wiki/deprecated-devices.
Other platforms can implement their own
isDeprecatedoverride on the future.A better approach is very welcome. The same for a future proof client-server implementation.
This one is trivial and tries to prevent some tickets :)
No worries, at some point in 2024 somebody will try to update from v2021.02 and we will get a ticket :p
This change is