New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArchiveViewer: view files #10683
ArchiveViewer: view files #10683
Conversation
else | ||
return | ||
end | ||
else | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we show an InfoMessage stating it failed?
I would switch the buttons, Will Extract create the full subdiretories ? Alongside the original file or elsewhere ? (I wonder if we'd really want to have these subdirectories, might be more bothering than anything after when one want to cleanup. |
No "Cancel" button, same as in other file popup dialogs. Tap outside to cancel. A file is extracted alongside the archive, with the full path. I think it is easier to find it this way. |
Which ones ? Tested a few (Delete, Reset, Open with, Rename), they all have a Cancel button. |
Long-press on a file in FM, History, Favorites. |
OK, the main ButtonTable - which doesn't have a Cancel, but many Buttons. |
If we have ideas for more buttons, "Cancel" will allow to keep the number even. |
"Extract without subdirectories" ? :) |
View archived files content (without extraction to a file).
ImageViewer is used for supported image files, TextViewer for all other types.
This change is