Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchiveViewer: view files #10683

Merged
merged 2 commits into from Jul 14, 2023
Merged

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Jul 12, 2023

View archived files content (without extraction to a file).
ImageViewer is used for supported image files, TextViewer for all other types.

1


This change is Reviewable

@hius07 hius07 added the Plugin label Jul 12, 2023
Comment on lines 210 to 214
else
return
end
else
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we show an InfoMessage stating it failed?

@poire-z
Copy link
Contributor

poire-z commented Jul 12, 2023

I would switch the buttons, Extract | View, View being the lest destructive (meaning it won't create/clutter files :) being on the right for easier access to right handed people.
No cancel button ? (I guess one can still tap outside to dismiss that window and do nothing?)

Will Extract create the full subdiretories ? Alongside the original file or elsewhere ? (I wonder if we'd really want to have these subdirectories, might be more bothering than anything after when one want to cleanup.
Also, given the limitations in target destination, is Extract really useful ? Now that we have View ?

@hius07
Copy link
Member Author

hius07 commented Jul 12, 2023

No "Cancel" button, same as in other file popup dialogs. Tap outside to cancel.

A file is extracted alongside the archive, with the full path. I think it is easier to find it this way.

@poire-z
Copy link
Contributor

poire-z commented Jul 12, 2023

No "Cancel" button, same as in other file popup dialogs.

Which ones ? Tested a few (Delete, Reset, Open with, Rename), they all have a Cancel button.

@hius07
Copy link
Member Author

hius07 commented Jul 12, 2023

Which ones ?

Long-press on a file in FM, History, Favorites.

@poire-z
Copy link
Contributor

poire-z commented Jul 12, 2023

OK, the main ButtonTable - which doesn't have a Cancel, but many Buttons.
But your above screenshot looks more like a ConfirmBox, with some info text, where we/I am used to see a Cancel - so it did surprise me a bit.
But ok with not having any, if you Consistency Officer feels it's no problem :)

@hius07
Copy link
Member Author

hius07 commented Jul 12, 2023

If we have ideas for more buttons, "Cancel" will allow to keep the number even.

@poire-z
Copy link
Contributor

poire-z commented Jul 13, 2023

"Extract without subdirectories" ? :)
(A bit too long for a button, and which of these 2 "Extract" would diserve to be on the right?...)
So, ok without Cancel.
(I think we may have some popup with a wide Close or Cancel button.)

@hius07 hius07 merged commit 3e43a21 into koreader:master Jul 14, 2023
3 checks passed
@hius07 hius07 deleted the archive-viewer-view-files branch July 14, 2023 04:57
@hius07 hius07 added this to the 2023.07 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants