Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceListener:onToggleFrontlight: add notification of "unchanged" #10727

Merged
merged 1 commit into from Jul 23, 2023

Conversation

hasezoey
Copy link
Contributor

@hasezoey hasezoey commented Jul 22, 2023

add notification when the frontlight is unchanged (no callback is called)

because in 2023.04 a notification would be always be shown (like Frontlight disabled) and since 2023.05 no notification would be shown anymore if the frontlight did not change (no intensity change), see

if self.fl_intensity == self.fl_min then return false end --- @fixme what the hell?

re #10722


This change is Reviewable

add notification when the frontlight is unchanged (no callback is called)
@pazos
Copy link
Member

pazos commented Jul 22, 2023

Pinging @NiLuJe, who worked recently on it (c.f #10597)

@NiLuJe
Copy link
Member

NiLuJe commented Jul 22, 2023

I stand by that quoted comment, but looks harmless, yeah ;).

@NiLuJe
Copy link
Member

NiLuJe commented Jul 22, 2023

Description is slightly misleading, though, it doesn't really have anything to do with the callback being called or not, the only cases where it returns false are explicitly that insane min test quoted, or if the fl is already on or off (depending).

@NiLuJe
Copy link
Member

NiLuJe commented Jul 22, 2023

or if the fl is already on or off (depending).

And that doesn't really apply to the "toggle" use-cases, but for direct "on"/"off" calls... which I'm not sure is even a thing that can be done by a user ;p.

@NiLuJe
Copy link
Member

NiLuJe commented Jul 22, 2023

Have I mentioned how much I hate the FL backend? ;p.

@pazos pazos merged commit 618f065 into koreader:master Jul 23, 2023
3 checks passed
@hasezoey hasezoey deleted the toggleShowDialog branch July 23, 2023 11:35
@Frenzie Frenzie added this to the 2023.07 milestone Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants