Bundle of misc fixes #10728
Merged
Bundle of misc fixes #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmm, you just included it? It is already excluded from assets (because we didn't want it on filesDir) And also seems to be excluded from initDataDir: https://github.com/koreader/koreader/blob/master/datastorage.lua#L68 |
|
Unless the dir no longer exists on the first place. In that case it is ok to remove it from the files to exclude :) |
|
Oh, hey, no, I'm just blind; missed that those were excludes ;p. (And I obviously only tested a non-Android build, so the fix is actually purely in base). |
|
Pushed an unrelated commit, so I'll rebase to merge ;p. |
NiLuJe
changed the title
Now that I've seen it in action on a device, it's mostly useless, and, if anything, confusing, because it's not static.
Fix OTAs on fresh installs (via koreader/koreader-base#1643)
e.g., at least the Clara 2E features the same controller & driver, but it is likely found on a few other models.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jul 28, 2023
Regression since koreader#10728, Fix koreader#10757
Frenzie
pushed a commit
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is