Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autowarmth: Change strings "set" and "unset" to "turn on" / "turn off" where appropriate #10733

Merged
merged 1 commit into from Jul 23, 2023

Conversation

hasezoey
Copy link
Contributor

@hasezoey hasezoey commented Jul 23, 2023

At least for that case i think Activate and Deactivate are more appropriate (especially for translations)

for example currently in german they are translated to:
Set -> Setzen (literally place / set)
Unset -> Löschen (literally delete)


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Jul 23, 2023

for example currently in german they are translated to:
Set -> Setzen (literally place / set)
Unset -> Löschen (literally delete)

Ftr, this was done by the native German-speaking author. We probably shouldn't bother him until August though. :-)

At least for that case i think Activate and Deactivate are more appropriate (especially for translations)

Turn on/off are already translated and should be equivalent in meaning.

@Frenzie Frenzie added the Plugin label Jul 23, 2023
@hasezoey
Copy link
Contributor Author

Turn on/off are already translated and should be equivalent in meaning.

you mean set/unset? because i couldnt find string turn on / turn off.

i think the meaning of Set is different in some places, like Set(on lets say a time or scale dialog) is different from Set(on a activate/deactivate context, like nightmode)

though i dont know enough about koreaders l10n (weblate), so just ignore / close this PR if you think this is not correct / worth it

@Frenzie
Copy link
Member

Frenzie commented Jul 23, 2023

you mean set/unset? because i couldnt find string turn on / turn off.

Your grep might need some maintenance. ;-) Turn on / Turn off is our standard string wherever appropriate, as opposed to Enable / Disable or Activate / Deactivate (or indeed Set / Unset, if it's used in that meaning).

@hasezoey
Copy link
Contributor Author

Your grep might need some maintenance

well, i did the search on weblate directly, via source:=Turn on (also without =)

Turn on / Turn off is our standard string wherever appropriate

should i change the PR to use that then?

@Frenzie
Copy link
Member

Frenzie commented Jul 23, 2023

source:=Turn on

If that's what you wrote there should probably be quotes around it.

should i change the PR to use that then?

Assuming it should be turn on/off, yes please!

@Frenzie Frenzie added this to the 2023.07 milestone Jul 23, 2023
@hasezoey
Copy link
Contributor Author

If that's what you wrote there should probably be quotes around it.

yes, now i see it found something

@Frenzie Frenzie changed the title Autowarmth: Change strings "set" and "unset" to "activate" / "deactivate" Autowarmth: Change strings "set" and "unset" to "turn on" / "turn off" where appropriate Jul 23, 2023
@Frenzie Frenzie merged commit d087710 into koreader:master Jul 23, 2023
3 checks passed
@hasezoey hasezoey deleted the autowarmthNightmode branch July 23, 2023 18:41
@zwim
Copy link
Contributor

zwim commented Jul 23, 2023

Fine with me.

To be consistent -> I will do a follow up PR changing "Use night mode" - "Turn on night mode" (and what is missing now a "Turn off night mode") soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants