New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autowarmth: Change strings "set" and "unset" to "turn on" / "turn off" where appropriate #10733
Conversation
Ftr, this was done by the native German-speaking author. We probably shouldn't bother him until August though. :-)
Turn on/off are already translated and should be equivalent in meaning. |
you mean i think the meaning of though i dont know enough about koreaders l10n (weblate), so just ignore / close this PR if you think this is not correct / worth it |
Your grep might need some maintenance. ;-) |
well, i did the search on weblate directly, via
should i change the PR to use that then? |
If that's what you wrote there should probably be quotes around it.
Assuming it should be turn on/off, yes please! |
yes, now i see it found something |
a77d2d8
to
d69c240
Compare
Fine with me. To be consistent -> I will do a follow up PR changing "Use night mode" - "Turn on night mode" (and what is missing now a "Turn off night mode") soon. |
At least for that case i think
Activate
andDeactivate
are more appropriate (especially for translations)for example currently in german they are translated to:
Set
->Setzen
(literallyplace
/set
)Unset
->Löschen
(literallydelete
)This change is