Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter: fixes #10765

Merged
merged 1 commit into from Aug 1, 2023
Merged

Exporter: fixes #10765

merged 1 commit into from Aug 1, 2023

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Jul 30, 2023

(1) Fix (unreported) crash on exporting Kindle My Clippings.txt.
It expected datetime string

-- Your Highlight on Page 123 | Added on Monday, April 21, 2014 10:08:07 PM

but my Kindle produces the space after the day, not comma.
- Your Highlight at location 12-12 | Added on Sunday, 30 July 2023 17:47:22

Let's have both options.

(2) When parsing the library, let's get author/title from doc_props, not from stats.

(3) When parsing the current document, do not reopen it to get author/title, just read doc_settings.


This change is Reviewable

@hius07 hius07 added the Plugin label Jul 30, 2023
@Frenzie Frenzie added this to the 2023.07 milestone Jul 30, 2023
@hius07 hius07 merged commit 7164bc2 into koreader:master Aug 1, 2023
3 checks passed
@hius07 hius07 deleted the exporter-fixes branch August 1, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants