copt deduplicate: font_size, visible_pages #10882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poire-z
approved these changes
Sep 8, 2023
| @@ -401,7 +401,7 @@ If any of the other Swipe to follow link options is enabled, this will work only | |||
| -- less visual feedback on PDF document of what is a link, or that we just | |||
| -- followed a link, than on EPUB, it's safer to not use them on PDF documents | |||
| -- even if the user enabled these features for EPUB documents). | |||
| if not self.ui.document.info.has_pages then | |||
| if not self.document.info.has_pages then | |||
There was a problem hiding this comment.
if self.ui.rolling ?
(A few of that below.)
| @@ -1561,9 +1557,9 @@ function ReaderRolling:checkXPointersAndProposeDOMVersionUpgrade() | |||
| end | |||
| if g_block_rendering_mode ~= 0 then -- default is not "legacy" | |||
| -- This setting is actually saved by self.ui.document.configurable | |||
There was a problem hiding this comment.
This comment can probably be updated or removed.
I can find one entry only. |
|
Yes, one entry of "visible_pages", but many other setting names with their short form, not the copt_ form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main discussion in: #10763.
This change is