Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copt/kopt options: deduplicate some defaults #10893

Merged
merged 9 commits into from Sep 13, 2023

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Sep 12, 2023

If G_defaults has a default value for a certain option, do not duplicate it anywhere.
(1) Remove not used default_arg.
(2) Deduplicate default setting of cre view_mode.
(3) Deduplicate default setting of djvu render_mode. Save render_mode to sdr for djvu documents only.


This change is Reviewable

@hius07 hius07 merged commit 3f677a7 into koreader:master Sep 13, 2023
3 checks passed
@hius07 hius07 deleted the options-deduplicate-default branch September 13, 2023 04:50
@hius07 hius07 added this to the 2023.09 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants