Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions for Go to first/last bookmark #10899

Merged
merged 4 commits into from Sep 15, 2023

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Sep 14, 2023

For cases like #10881.

1


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Sep 14, 2023

Incidentally, is it correct that we don't have an action for "next" (not as in next page but next section of page)? See https://www.mobileread.com/forums/showthread.php?p=4356097#post4356097

@Frenzie Frenzie added this to the 2023.09 milestone Sep 14, 2023
@hius07
Copy link
Member Author

hius07 commented Sep 14, 2023

turn pages, which when set to 1 is not the same thing as tapping on the right side of the screen

Looks like the same

page_jmp = {category="absolutenumber", event="GotoViewRel", min=-100, max=100, title=_("Turn pages"), reader=true},

id = "tap_forward",
ges = "tap",
screen_zone = forward_zone,
handler = function()
if G_reader_settings:nilOrFalse("page_turns_disable_tap") then
return self:onGotoViewRel(1)
end
end,

@Frenzie
Copy link
Member

Frenzie commented Sep 14, 2023

In that case the UI string is deceptive, but possibly only to someone who's acutely aware of the distinction?

@hius07 hius07 merged commit be125af into koreader:master Sep 15, 2023
2 of 3 checks passed
@hius07 hius07 deleted the go-to-first-last-bm branch September 15, 2023 04:24
@ryanwwest
Copy link
Contributor

Oh cool! Thanks for doing this, no need for profiling this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants