History: update on renaming/moving a folder #10999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poire-z
reviewed
Oct 12, 2023
Comment on lines
+207
to
+209
| local file, count = v.file:gsub(old_path, new_path) | ||
| if count == 1 then | ||
| self.hist[i].file = file |
There was a problem hiding this comment.
About the :gsub(), I guess you should try to match at start, and limit the nb of replacements to 1 (4th parameter, or no need if matching at start).
So sick cases like renaming bits of /mnt/onboard/Library/Fiction/mnt/onboard/Library/myfile.epub are supported :)
poire-z
approved these changes
Oct 12, 2023
Frenzie
reviewed
Oct 12, 2023
| @@ -199,6 +200,22 @@ function ReadHistory:updateItemByPath(old_path, new_path) | |||
| end | |||
| end | |||
|
|
|||
| --- Updates the history list after renaming/moving a folder. | |||
| function ReadHistory:updateItemsByPath(old_path, new_path) | |||
| old_path = "^"..old_path | |||
There was a problem hiding this comment.
Oof, this was so confusing to me. I think it'd be much clearer straight in the gsub, heh. :-)
There was a problem hiding this comment.
straight in the gsub
It's in the loop.
There was a problem hiding this comment.
Or old_path_pattern instead of just old_path
Frenzie
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10995.
(Doesn't update sdr with "dir" setting, but that's another story)
This change is