Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color highlight menu #11044

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Add color highlight menu #11044

wants to merge 28 commits into from

Commits on Jan 21, 2024

  1. Add color highlight menu

    @smasher816 @NiLuJe
    smasher816 authored and NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    5e4a437 View commit details
    Browse the repository at this point in the history

  2. LuaCheck'ed

    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a6c6b49 View commit details
    Browse the repository at this point in the history

  3. Honor the ligthen_factor with colors

    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    45cc8b6 View commit details
    Browse the repository at this point in the history

  4. Random 7AM idea is random 

    But feels better than an OVER blend.
    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    bc3aeab View commit details
    Browse the repository at this point in the history

  5. More random musings

    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a022915 View commit details
    Browse the repository at this point in the history

  6. I can word good now!

    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    9bf0e4e View commit details
    Browse the repository at this point in the history

  7. This moved to base

    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    d971a14 View commit details
    Browse the repository at this point in the history

  8. As we effectiuvely only have a single call site for those, 

    move the color type check here, instead of withing BlitBuffer.

That thing is already a burden on the JIT, let's avoid gratuitous
branches deep in it that 99% of the code will never take...
    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    2d9e734 View commit details
    Browse the repository at this point in the history

  9. Finally took the opportunity to fix a 10 year old TODO about the 

    misnamed lighten/dimRect methods...
    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    6e6e9fc View commit details
    Browse the repository at this point in the history

  10. Mkay, i'm going to assume the MUL vs. OVER comes from MuPDF...

    @NiLuJe
    NiLuJe committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a158148 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Unbreak darkenRect

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0e403a1 View commit details
    Browse the repository at this point in the history

  2. Drop redudant saveSetting calls

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bf56868 View commit details
    Browse the repository at this point in the history

  3. Slightly less awful color highlights in sw nm

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1d9fd2f View commit details
    Browse the repository at this point in the history

  4. Hmm, pretty colors.

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bbb2d9d View commit details
    Browse the repository at this point in the history

  5. Restore colorful bg support in textBoxWidget 

    And use it for the color sleection popup
    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c7a6cf5 View commit details
    Browse the repository at this point in the history

  6. Cache the type check

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c84de40 View commit details
    Browse the repository at this point in the history

  7. Add cyan, and make blue actually blue.

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ed6859d View commit details
    Browse the repository at this point in the history

  8. More logical color order

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fbde4ed View commit details
    Browse the repository at this point in the history

  9. This is always set, no need for a runtime fallback

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8e1a97a View commit details
    Browse the repository at this point in the history

  10. TextBoxWidget: Eh, handle color fgs, too. 

    Bit silly to only do half when we can do both, even if nobody will ever
use it ;p.
    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    32f3fbe View commit details
    Browse the repository at this point in the history

  11. Make Gray our actual legacy grayscale highlights (i.e., it'll follow the 

    opacity setting).
    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7ba3226 View commit details
    Browse the repository at this point in the history

  12. Move the Highlight color menu inside the Highlight Stule dialog 

    And enable color even outside of isColorScreen, for interop
    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d314c12 View commit details
    Browse the repository at this point in the history

  13. Don't allow changin colors if drawer is invert

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    21d435f View commit details
    Browse the repository at this point in the history

  14. Revert "Don't allow changin colors if drawer is invert" 

    This reverts commit 21d435f.
    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    447c92b View commit details
    Browse the repository at this point in the history

  15. Less clunky and more user-friendly warning when you try to modify colors 

    if style is set to underline.

I can't really just disable the button AFAICT?
    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9d7f70b View commit details
    Browse the repository at this point in the history

  16. Might want to drop the bg on actual eInk screens, will have to test

    @NiLuJe
    NiLuJe committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e136c07 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Don't default to yellow HLs on grayscale screens

    @NiLuJe
    NiLuJe committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0c6a453 View commit details
    Browse the repository at this point in the history

  2. Fancy bgcolor in the *other* popup, too 

    And factually lookup the right color name, too; not the translated string
    @NiLuJe
    NiLuJe committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    117d18d View commit details
    Browse the repository at this point in the history