Page browser: show nightmode thumbnails when in nightmode #11091
Conversation
Just prevent page thumbnails ImageWidgets to be nightmode inverted, unlike all other ones which are expected to be double inverted to get their original colors shown. The same thumbnail can be used and cached in both day and night modes, unless "nightmode_images" is enabled and have crengine itself invert images, making thumbnails different.
| @@ -250,6 +250,10 @@ end | |||
| function ReaderThumbnail:getPageThumbnail(page, width, height, batch_id, when_generated_callback) | |||
| self:setupCache() | |||
| self.current_target_size_tag = string.format("w%d_h%d", width, height) | |||
| if self.ui.rolling and Screen.night_mode and self.ui.document.configurable.nightmode_images == 1 then | |||
| -- We'll get a different bb in this case: it needs it own cache hash | |||
There was a problem hiding this comment.
über nit: final it should be an its ;).
| @@ -250,6 +250,10 @@ end | |||
| function ReaderThumbnail:getPageThumbnail(page, width, height, batch_id, when_generated_callback) | |||
| self:setupCache() | |||
| self.current_target_size_tag = string.format("w%d_h%d", width, height) | |||
| if self.ui.rolling and Screen.night_mode and self.ui.document.configurable.nightmode_images == 1 then | |||
| -- We'll get a different bb in this case: it needs it own cache hash | |||
| self.current_target_size_tag = self.current_target_size_tag .. "_ni" | |||
There was a problem hiding this comment.
(ni meant "nightmode images", but ok :)
My emulator and device are old, and so soft. I don't have a Kobo with hardware nightmode. |
Every Kobo (except for the Aura, unless it's on a recent FW; and except for the sunxi ones) supports hardware inversion, so yours should be using HW inversion ;). |
|
Well, ok :) (I thought there was a toggle in the menu to switch between hard/soft, but looks like there isn't). |
|
Oh, yeah, I also mistakenly thought I added a switch for that in dev settings, but, nope, that's dithering only. (It indeed makes no sense to disable HW inversion: either it works and it's free performance, or it doesn't and we just kill it by default). |
Just prevent page thumbnails ImageWidgets to be nightmode inverted, unlike all other ones which are expected to be double inverted to get their original colors shown.
The same thumbnail can be used and cached in both day and night modes, unless "nightmode_images" is enabled and have crengine itself invert images, making thumbnails different.
(Had a hard time writing that commit message :) was initially mentionning "triple inverting"... hard to put into words what's happening in nightmode and the simple tweaks there).
See #10811 (comment)
Pinging @NiLuJe for your OK the the ImageWidget
original_in_nightmode = trueidea/wording.This change is