ScreenSaverLock: Hide the popup on suspend ^2

[NiLuJe]

Because GH ate a commit during a rebase for some reason (it's fine locally, whatever).

Replaces #11170

---

This change is 

[mergen3107]

I reverted patch 11170, then applied this patch 11174.

Works great!
Here is the verbose log.
crash_11174_ss2.log.txt

When unlock - message shows up and frointlight turens on. When I lock it back - message goes away, whole screen refreshes, frontlight goes off.

The same with the sleep cover.
One intersting thing I found (tried a few time in the very end of the log) is that if semi-close the cover - the message goes away, screen flashes, but frontlight and KOReader stay up. Don't know if this is intended or not.

[NiLuJe]

Don't know if this is intended or not.

I have absolutely no idea what the native system does with sleep covers; but as far as we're concerned, the IntoSS and OutOfSS Events are all properly in step lock, so it all looks good.

[mergen3107]

The same behaviour can be achieved if:

• press power button - see message
• rotate the screen upside down - screen rotates, message goes agay, frontlight stays on

[NiLuJe]

I don't have a sleep cover to test with, but my trusty fridge magnet seems to behave as well as can be expected.

I have seen it take a few seconds to "register" a "close" sometimes (and also a few cases of close -> open jitter, but, again, I'm placing a magnet by hand so this is pretty inaccurate to begin with ;p).

[NiLuJe]

Fun fact: the lipc events pass a different argument depending on the source of the wakeup (c.f., lipc-wait-event -m -s 0 -t com.lab126.powerd '*').

Button:

goingToScreenSaver 2
outOfScreenSaver 1

Hall sensor:

goingToScreenSaver 4
outOfScreenSaver 6

Not that this would help us much, as we don't really control the whole thing unlike on Kobo, but, still, fun tidbit nonetheless. (I'm also not confident those arguments would be quite portable, this is on a PW2).

[NiLuJe]

TL;DR: So, yeah, this looks as ready as it'll ever be.

[NiLuJe]

• rotate the screen upside down - screen rotates, message goes agay, frontlight stays on

That one makes perfect sense, actually.

That message is a hack, it's a one-time paint job, not a real widget. Anything that requires a redraw will effectively dismiss it. And, of course, rotation requires a redraw ;).

On the upside, if the device were actually asleep, you shouldn't be able to rotate it (assuming the gyro isn't a wakeup source and/or it's handled properly if it is).

[NiLuJe]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)

[mergen3107]

Looks and works great! Thank you NiLuJe!