New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folder check in move-to-archive #11262
Merged
Frenzie
merged 7 commits into
koreader:master
from
mergen3107:Move-to-archive-add-folder-check
Dec 27, 2023
Merged
Add folder check in move-to-archive #11262
Frenzie
merged 7 commits into
koreader:master
from
mergen3107:Move-to-archive-add-folder-check
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supposed to close #11245
I tested quickly on Kindle Scribe. Thanks! |
(OK, CircleCI stopped complaining, I hope I did it right... :D) |
NiLuJe
reviewed
Dec 25, 2023
Thank you guys! Is this way better? :D |
NiLuJe
reviewed
Dec 25, 2023
Frenzie
reviewed
Dec 27, 2023
Frenzie
approved these changes
Dec 27, 2023
NiLuJe
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try.
Function is taken from: https://www.geeks3d.com/hacklab/20210901/how-to-check-if-a-directory-exists-in-lua-and-in-python/
Use case:
This change is