New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add viewport for PB743K3 #11302
Add viewport for PB743K3 #11302
Conversation
The bezel covers a couple of pixels of the screen, so adjust not to show content under the bezel.
I wouldn't mind someone with the same device double-checking that this isn't just shoddy build quality on your particular device ;). That's not to discount the fact that some OEMs do like to put bits of screens behind bezels, but it's usually in a slightly less wonky fashion (i.e., one side only, usually top or bottom). |
@NiLuJe @SilverGreen93 I just tested this in my PocketBook InkPad Color 3. I used the nightly build koreader-pocketbook-v2023.10-82-g5d2a44106_2023-12-29 from https://build.koreader.rocks/download/nightly/v2023.10-82-g5d2a44106_2023-12-29/ I used the PDF sample that I attach here so you can compare with the same reference. I set KoReader to "auto" page crop and 0.00 margin. Here are some screenshots This is an extreme setting that I would probably never use (although I am new to KoReader and using an eReader this week for the first time after 10 years so I don't know how I will use it yet) but I see what you mean by part of the screen being under the bezel. I would say that in my device there is a bit more under the bezel in the right side than in the left side, and in some of my screenshots you can see that the m in "Ut ac lorem" in the very first line of that page, almost almost goes under the bezel to the point that my left eye can see the right side pixels of the "m" and the right eye might be missing the very last colum of pixels of that "m" if the screen is centered towards my face. However the rest of the sentences seem to finish 1 or more pixels more to the left side and it is not as tight. EDIT: |
What's the full panel resolution supposed to be exactly? (So I can grok how much the viewport actually crops on the right & bottom ;)). |
According to the specifications of the device: |
Oh, so that's a fairly good chunk of cropping there. |
The bezel covers a couple of pixels of the screen, so adjust not to show content under the bezel.
This fixes #11301
This change is