revert auto crop fix #11325
revert auto crop fix #11325
Conversation
|
The or thing crossed my mind while looking at the original check. I can't speak to the rest (i.e., tweaking the coords), though, and am not able to even look up the rest of the code for a few days ;). |
|
This tweaking will also cause some problems. The values will be overridden here: https://github.com/koreader/koreader/blob/master/frontend/apps/reader/modules/readerview.lua#L668. But I found the cause of the problem is because of the margins: Test with the uncropped cbz: When we enter the area of kopt (koptcrop.c - https://github.com/koreader/libk2pdfopt): The source page (0,0) - (848,1199) You can see that originally only the width was cropped from 848 to 777. This is because there is no white area to be cropped in the height direction. However, the margin of 10.396947 is applied uniformly and extends to the height direction as well, increasing it from 1199 to 1209.396973. This causes the bbox to be larger than the page, resulting in the original page being rendered instead of the bbox. I found a workaround for this problematic cbz file: we set the koreader margin to 0 so that no margin will be added, and the cropped bbox will be rendered.
It would be better to support separate margins for the w and h positions (having some margins in the w from 848 to 777 would be good) but for now since the cbz cropped issue can be fixed with the workaround will revert to the original here. |
A change in koptcrop for better margins, as mentioned in the comment: koreader/koreader#11325 (comment). The bbox shouldn't be smaller than the page again, unless there's a DPI problem, who knows... I didn't exhaustively test the semi-auto and manual crop modes... But only if @poire-z finds if is logical :D
A change in koptcrop for better margins, as mentioned in the comment: koreader/koreader#11325 (comment).
the first commit I revert the changes from #11194 in favor of #11291
the second commit is another try
This change is