PathChooser: fix calling Folder shortcuts #11367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Jan 16, 2024
frontend/ui/widget/pathchooser.lua
Outdated
| @@ -117,15 +115,15 @@ function PathChooser:onMenuHold(item) | |||
| if self.detailed_file_info then | |||
| local filesize = util.getFormattedSize(attr.size) | |||
| local lastmod = os.date("%Y-%m-%d %H:%M", attr.modification) | |||
| title = T(_("Choose this file?\n\n%1\n\nFile size: %2 bytes\nLast modified: %3"), | |||
| title = T(_("Choose this file?\n\n%1\n\nFile size: %2 bytes\nLast modified: %3\n"), | |||
There was a problem hiding this comment.
It's better to append all of these. Not only in general so as not to bother the translators with random newlines before or after, but especially here since these strings are already translated in their current form. (In reverse I'm open to it, i.e., changing a \n at the end to an appended \n.)
poire-z
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the bug:
-open Folder shortcuts
-press the Plus icon to add a shortcut
-in PathChooser long-press the Home icon
-press Folder shortcuts button
-close Folder shortcuts, close PathChooser
-press a shortcut
Folder shortcuts window remains open.
This change is