Clear UI leftovers before doing an OTA-install #11412
Conversation
|
I feel like https://xkcd.com/1172/ but I've always enjoyed being. able to continue reading while that's happening. 😊 Edit: although that might be more of a comment on #9114. |
frontend/device/generic/device.lua
Outdated
| text = _("Update is ready. Install it?"), | ||
| ok_text = _("Now"), |
There was a problem hiding this comment.
I'd rather just keep this as is, or perhaps Update now.
frontend/device/generic/device.lua
Outdated
| @@ -405,9 +405,10 @@ end | |||
|
|
|||
| function Device:install() | |||
| local ConfirmBox = require("ui/widget/confirmbox") | |||
| local ignore_events = {"swipe", "hold", "hold_release", "hold_pan", "touch", "pan", "pan_release"} | |||
There was a problem hiding this comment.
If we really need to have some ConfirmBox and InfoMessage unmovable (and less need to have some events ignored but other not ignored), it could be simpler to pass unmovable=true to these widgets, which would pass it to their MovableContainer, and have:
function MovableContainer:init()
if Device:isTouchDevice() and not self.unmovable then(Even if it is strange to have an unmovable MovableContainer :) but that can be explained with a comment -- this can be passed whe needed to have MovableContainer present but a no-op, so we don't have to change the widget layout or something.)
This is the logical continuation of #9114.
In #9114 the screen is cleared before downloading an update.
Then (unchanged by this PR) a ConfirmBox to ask for a confirmation of the new update is shown.
... no changes ...
After the successful download the user is asked to finally install the update.
Changes in this PR:
1.) Ask the user explicitly to update now or later. (No change in functionality,but only in texting, as later could have been selected by tapping outside the dialog before).
2.) Clear the screen before update, so that the user does only see whats happening (and not fragments of the book)..
Draft because: Does anybody know an easy solution to prevent the ConfirmBox to be movable (because moving it, shows some fragments of theold book's text)?
This change is