Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: better conformance to the HTML Standard rendering #11527

Merged
merged 5 commits into from Mar 10, 2024

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented Mar 9, 2024

bump crengine: better conformance to the HTML Standard rendering

Includes:

Also update to libunibreak 6.0.

ReaderTypeset: tweak Style> menu logic and defaults

  • Reword and document most menu items.
  • Handle internally two default styles, one applying only to FB2/FB2 books, and the other to all other formats.
  • Also don't reset the stylesheet to epub.css when toggling Embedded Styles to off.
  • Closes RFC: Style>Auto, fb2.css, epub.css, html5.css #11494.

Style tweaks: add tweak to avoid some presentational hints

util.prettifyCSS(): handle better :is() and similar

Wikipedia: tweak EPUB css to force epub.css look

Include in the EPUB stylesheet most of our epub.css tweaks, so we get our expected styling even when html5.css is used as the default stylesheet.
(Users liking the "web page" look can still get it by enabling some of our existing style tweaks.)
Discussed around #10770 (comment).


This change is Reviewable

@poire-z poire-z added this to the 2024.04 milestone Mar 9, 2024
@poire-z
Copy link
Contributor Author

poire-z commented Mar 10, 2024

Quick review of my English wordings please?

@Frenzie
Copy link
Member

Frenzie commented Mar 10, 2024 via email

Includes:
- Hyphenation: update French.pattern
- [CI] Add stylelint to help prevent typos in CSS
- In-page footnotes: better handle duplicated ids
- lvrend: handle in-page footnotes in table <caption>
- lvstsheet: fix compiler warnings
- LVString: ignore CJK chars in lStr_findWordBounds()
- lvtext: AddLine(): handle some CJK + space edge case
- EPUB: look for EPUB3 cover even when EPUB2 cover advertized
- List items: proper per-specs positionning and sizing
- epub.css: add/use "@media (-cr-max-cre-dom-version: 20180527)"
- fb2def.h: add more HTML element and attributes names
- CSS: generic support for handling presentational hints
- CSS: add support for private -cr-apply-func:
- ldomDocumentWriterFilter: remove attribute to CSS conversion
- lvrend: more proper rendering of block images
- lvrend: keep margin_left/right updated when "auto"
- CSS: add support for handling HTML's align= attribute
- lvrend: fix HR and images positionning when floats involved
- epub.css, html5.css: minor updates for easier stylesheet switch
- epub.css, html5.css: major updates for better conformance
- fb2.css: fix CI stylelint warnings
Also update to libunibreak 6.0.
- Reword and document most menu items.
- Handle internally two default styles, one applying only
  to FB2/FB2 books, and the other to all other formats.
- Also don't reset the stylesheet to epub.css when
  toggling Embedded Styles to off.
Include in the EPUB stylesheet most of our epub.css
tweaks, so we get our expected styling even when
html5.css is used as the default stylesheet.
(Users liking the "web page" look can still get it
by enabling some of our existing style tweaks.)
@poire-z poire-z merged commit 0eaa2d8 into koreader:master Mar 10, 2024
2 of 3 checks passed
@poire-z poire-z deleted the bump_crengine branch March 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants