appimage: get full path before changing to assets dir #11552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
approved these changes
Mar 15, 2024
My bad. The appimage predates the debian build and I didn't think about this change back then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in https://github.com/koreader/koreader/blob/master/platform/debian/koreader.sh
If one and only one argument is passed and the argument is a path that exists on the filesystem get its absolute path and pass it to lua, because assets dir != pwd and it is impossible to resolve relative paths from there.
Needs to be improved, here on in the future, to handle short options. The most effective way would be to pass
pwdas a parameter and let the frontend to joinpwdandpath. So the frontend takes care of everything :)Feedback welcome.
Closes #11518
This change is