Ensure that the pan zoom direction is not nil #11557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix gif and web files not opening: koreader#11425 (comment)
poire-z
approved these changes
Mar 17, 2024
Frenzie
reviewed
Mar 17, 2024
| @@ -695,7 +695,8 @@ function ReaderView:recalculate() | |||
| -- start from right of page_area | |||
| self.visible_area.x = self.page_area.x + self.page_area.w - self.visible_area.w | |||
| end | |||
| if self.document.configurable.zoom_direction >= 2 and self.document.configurable.zoom_direction <= 5 then -- zoom_bottom_to_top | |||
| -- Check if we are in zoom_bottom_to_top | |||
| if self.document.configurable.zoom_direction and self.document.configurable.zoom_direction >= 2 and self.document.configurable.zoom_direction <= 5 then | |||
There was a problem hiding this comment.
This would be nil before ReaderZooming is loaded or some such?
There was a problem hiding this comment.
Probably configurable.zoom_direction is never nil for mupdf engine but can be nil for Image view or Picture Document engines, maybe not even requiring this module or such at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gif and web files not opening: #11425 (comment)
This change is