Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoverBrowser: fix file popup dialog #11576

Merged
merged 1 commit into from
Mar 20, 2024
Merged

CoverBrowser: fix file popup dialog #11576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/coverbrowser.koplugin/covermenu.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,9 @@ function CoverMenu:updateItems(select_number)
-- we replace it by ours.
-- (FileManager may replace file_chooser.showFileDialog after we've been called once, so we need
-- to replace it again if it is not ours)
if self.showFileDialog and self.showFileDialog ~= self.showFileDialog_ours then
if self.path -- FileManager only
and (not self.showFileDialog_ours -- never replaced
or self.showFileDialog ~= self.showFileDialog_ours) then -- it is no more ours
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer :-p

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored original wordings from #2940.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a way @poire-z likes to put it. ;-P Anyway, as stated merging is fine by me, but it should be "no longer" ^_^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Yes, my English is a bit unstable on "no more" vs. "no longer" :))

-- We need to do it at nextTick, once FileManager has instantiated
-- its FileChooser completely
UIManager:nextTick(function()
Expand Down