Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard: detect tap if swipes are disabled #11699

Merged
merged 1 commit into from Apr 24, 2024
Merged

Keyboard: detect tap if swipes are disabled #11699

merged 1 commit into from Apr 24, 2024

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Apr 20, 2024 •
edited by Frenzie

Discussed in #11668.

This change is Reviewable

@Frenzie Frenzie added this to the 2024.04 milestone Apr 20, 2024
Frenzie
Frenzie approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit hard to gauge, not too much risk of false positives?

@hius07
Copy link
Member Author

hius07 commented Apr 20, 2024

koreader/frontend/ui/elements/menu_keyboard_layout.lua

Line 164 in bfc8479

text = _("Swipe to input additional characters"),

Maybe two separate settings instead?
Disable swipes
Detect tap instead of swipe

@Frenzie
Copy link
Member

Frenzie commented Apr 20, 2024

That's probably not necessary?

@Frenzie Frenzie merged commit f5be04a into koreader:master Apr 24, 2024
2 of 3 checks passed
@hius07 hius07 deleted the key-swipe branch April 25, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024.04
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hius07 @Frenzie