Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReaderHighlight] Remove duplicated setting on NT devices #11750

Merged
merged 3 commits into from
May 11, 2024
Merged

[ReaderHighlight] Remove duplicated setting on NT devices #11750

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6786209
remove duplicated setting
Commodore64user May 4, 2024
aefd8c1
minor comment-wording change
Commodore64user May 4, 2024
e27e9f0
tableDeepCopy removed as not needed
Commodore64user May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions frontend/apps/reader/modules/readerhighlight.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,11 +589,12 @@ Except when in two columns mode, where this is limited to showing only the previ
end,
})

-- long_press menu is under taps_and_gestures menu which is not available for non touch device
-- Clone long_press menu and change label making much meaning for non touch devices
-- long_press setting is under taps_and_gestures menu which is not available for non-touch devices
-- Clone long_press setting and change its label, making it much more meaningful for non-touch device users.
if not Device:isTouchDevice() and Device:hasDPad() then
menu_items.selection_text = util.tableDeepCopy(menu_items.long_press)
menu_items.selection_text.text = _("Select on text")
menu_items.selection_text = menu_items.long_press
menu_items.selection_text.text = _("Selection on text")
menu_items.long_press = nil
Commodore64user marked this conversation as resolved.
Show resolved Hide resolved
end

-- main menu Search
Expand Down