-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tweak_buttons_func with an event instead #11777
Replace tweak_buttons_func with an event instead #11777
Commits on May 7, 2024
-
Fill in extra buttons via Event
nairyo committedMay 7, 2024 Configuration menu - View commit details
-
Copy full SHA for cdea878 - Browse repository at this point
Copy the full SHA cdea878View commit details -
Attempt to get rid of tweak_buttons_func completely
nairyo committedMay 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 7111161 - Browse repository at this point
Copy the full SHA 7111161View commit details -
Insert inner widgets in container
nairyo committedMay 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 5c4c44a - Browse repository at this point
Copy the full SHA 5c4c44aView commit details
Commits on May 8, 2024
-
Only consume event in correct button, consume event when correct item…
… wasn't due yet, call function on parent widget
nairyo committedMay 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 57ad5c3 - Browse repository at this point
Copy the full SHA 57ad5c3View commit details
Commits on May 9, 2024
-
Inserting VocabularyBuilderWidget in plugin table does weird things, …
…so avoid it
nairyo committedMay 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 752d0f7 - Browse repository at this point
Copy the full SHA 752d0f7View commit details -
remove unnecessary comment and debug id
nairyo committedMay 9, 2024 Configuration menu - View commit details
-
Copy full SHA for ae7e999 - Browse repository at this point
Copy the full SHA ae7e999View commit details -
nairyo committed
May 9, 2024 Configuration menu - View commit details
-
Copy full SHA for df34df0 - Browse repository at this point
Copy the full SHA df34df0View commit details
Commits on May 10, 2024
-
Make sure iter returns nil once we go out of bounds
nairyo committedMay 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 5294799 - Browse repository at this point
Copy the full SHA 5294799View commit details -
Only try showing vocabbuilder specific dict popup when we're not deal…
…ing with nested lookups
nairyo committedMay 10, 2024 Configuration menu - View commit details
-
Copy full SHA for b12c532 - Browse repository at this point
Copy the full SHA b12c532View commit details -
get rid of Close events, we already have access to the dict popup win…
…dow we're trying to close
nairyo committedMay 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 09f1ede - Browse repository at this point
Copy the full SHA 09f1edeView commit details -
small cleanup - move VocabItemWidget related function up where it bel…
…ongs
nairyo committedMay 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 00fc519 - Browse repository at this point
Copy the full SHA 00fc519View commit details
Commits on May 12, 2024
-
Get rid of onClose as much as possible. Return to initial implementat…
…ion now that event propagation issue seems to be gone
nairyo committedMay 12, 2024 Configuration menu - View commit details
-
Copy full SHA for f4e5bbd - Browse repository at this point
Copy the full SHA f4e5bbdView commit details -
PR feedback - use WidgetContainer:clear()
nairyo committedMay 12, 2024 Configuration menu - View commit details
-
Copy full SHA for e8bcf65 - Browse repository at this point
Copy the full SHA e8bcf65View commit details
Commits on May 13, 2024
-
rollback - onClose() is the way
nairyo committedMay 13, 2024 Configuration menu - View commit details
-
Copy full SHA for ca1947f - Browse repository at this point
Copy the full SHA ca1947fView commit details -
Don't consume Close event, this widget still exists after we've been …
…closed, meaning we are now consuming Close events which are meant to go to the reader/filemanager
nairyo committedMay 13, 2024 Configuration menu - View commit details
-
Copy full SHA for b78a3eb - Browse repository at this point
Copy the full SHA b78a3ebView commit details -
nairyo committed
May 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 2545964 - Browse repository at this point
Copy the full SHA 2545964View commit details -
Another attempt: make sure VocabularyBuilderWidget is destroyed fully…
… when closing the window Some of the callback stuff can just sit in the VocabularyBuilderWidget directly too so change that as well
nairyo committedMay 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 5dcc7f4 - Browse repository at this point
Copy the full SHA 5dcc7f4View commit details