Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tweak_buttons_func with an event instead #11777

Merged
merged 17 commits into from
May 16, 2024

Commits on May 7, 2024

  1. Fill in extra buttons via Event

    nairyo committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cdea878 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7111161 View commit details
    Browse the repository at this point in the history
  3. Insert inner widgets in container

    nairyo committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5c4c44a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Only consume event in correct button, consume event when correct item…

    … wasn't due yet, call function on parent widget
    nairyo committed May 8, 2024
    Configuration menu
    Copy the full SHA
    57ad5c3 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Inserting VocabularyBuilderWidget in plugin table does weird things, …

    …so avoid it
    nairyo committed May 9, 2024
    Configuration menu
    Copy the full SHA
    752d0f7 View commit details
    Browse the repository at this point in the history
  2. remove unnecessary comment and debug id

    nairyo committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ae7e999 View commit details
    Browse the repository at this point in the history
  3. remove debug message I missed

    nairyo committed May 9, 2024
    Configuration menu
    Copy the full SHA
    df34df0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    5294799 View commit details
    Browse the repository at this point in the history
  2. Only try showing vocabbuilder specific dict popup when we're not deal…

    …ing with nested lookups
    nairyo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b12c532 View commit details
    Browse the repository at this point in the history
  3. get rid of Close events, we already have access to the dict popup win…

    …dow we're trying to close
    nairyo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    09f1ede View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00fc519 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Get rid of onClose as much as possible. Return to initial implementat…

    …ion now that event propagation issue seems to be gone
    nairyo committed May 12, 2024
    Configuration menu
    Copy the full SHA
    f4e5bbd View commit details
    Browse the repository at this point in the history
  2. PR feedback - use WidgetContainer:clear()

    nairyo committed May 12, 2024
    Configuration menu
    Copy the full SHA
    e8bcf65 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. rollback - onClose() is the way

    nairyo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ca1947f View commit details
    Browse the repository at this point in the history
  2. Don't consume Close event, this widget still exists after we've been …

    …closed, meaning we are now consuming Close events which are meant to go to the reader/filemanager
    nairyo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b78a3eb View commit details
    Browse the repository at this point in the history
  3. fewer changes

    nairyo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2545964 View commit details
    Browse the repository at this point in the history
  4. Another attempt: make sure VocabularyBuilderWidget is destroyed fully…

    … when closing the window
    
    Some of the callback stuff can just sit in the VocabularyBuilderWidget directly too so change that as well
    nairyo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5dcc7f4 View commit details
    Browse the repository at this point in the history