Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT: add Hot swapping dictionaries button and edit button into FocusManager's layout #11803

Merged
merged 1 commit into from
May 12, 2024

Conversation

comphilip
Copy link
Contributor

@comphilip comphilip commented May 12, 2024

fix #11783


This change is Reviewable

@Frenzie Frenzie added this to the 2024.05 milestone May 12, 2024
@Frenzie Frenzie added the NT Non Touch devices label May 12, 2024
@Frenzie Frenzie merged commit f0a3bcf into koreader:master May 12, 2024
3 checks passed
@Frenzie
Copy link
Member

Frenzie commented May 12, 2024

Thanks!

@Commodore64user
Copy link
Contributor

Blimey! This was swift and unexpected. Thanks!

@comphilip comphilip deleted the fix-11783 branch May 13, 2024 09:42
@jospalau
Copy link

jospalau commented May 13, 2024

Hello,
When looking for a word in the dictionary, it gets hanged in Searching dictionary for: ...

Not sure if it is my configuration though but it works removing this change.

It works in the emulator but not in any of my other devices. Looking I have been that self.button_table.layout comes as nil

In buttontable.lua there is something like if Device:hasDPad() then self.layout = self.buttons_layout

That may be then since non of my devices has it

@Frenzie
Copy link
Member

Frenzie commented May 13, 2024

Are you sure you don't have the version from 2 or 3 days ago?

@jospalau
Copy link

I updated to the last nightly to test, it is showing 2024.04-48

I could have something mangled here in any case if this should be working

@Frenzie
Copy link
Member

Frenzie commented May 13, 2024

No, it doesn't seem to finish on my Kobo. I'd quickly tested on Android before, but I guess it registers as hasDPad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NT Non Touch devices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot swapping dictionaries unavailable on NT devices
4 participants