Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LuaJIT profiling support (lulip), better cmdline option handling. #204

Merged
merged 5 commits into from
Aug 10, 2013

Conversation

thotypous
Copy link
Member

Added the profiler, as discussed in issue #200. I still need to work in getAutoBBox before closing the issue. I will work on it later today or tomorrow when I get some time.

@houqp
Copy link
Member

houqp commented Aug 7, 2013

hrm , could you rebase on the current master? also it would be better to move lulip module after koreader-base refactoring is done :)

it looks great 👍

@thotypous
Copy link
Member Author

Did a merge instead of a rebase, I'm not very used to git yet :P
Agreed on moving it after the refactoring is done. KOReader will look simply great after that reorganization! 👍

if ARGV[1] == "-h" then
return showusage()
end
DEBUG = function() end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, turns out that you cannot over write DEBUG function by default, you will never be able to turn it on back later ;p

@thotypous
Copy link
Member Author

Hm, sorry, I was sure I had tested it, but I had only checked the ev.log, and forgot to see stdout. I will fix that.

@thotypous
Copy link
Member Author

Done, fixed. I also had to apply the patch from your pull request #208 to be able to test, but I did not push it into my fork.

@houqp
Copy link
Member

houqp commented Aug 10, 2013

nice work! the output even have syntax highlight, haha

houqp added a commit that referenced this pull request Aug 10, 2013
Added LuaJIT profiling support (lulip), better cmdline option handling.
@houqp houqp merged commit e0c4b46 into koreader:master Aug 10, 2013
houqp added a commit to houqp/koreader that referenced this pull request Apr 24, 2017
Proper regal waveform support on the PW2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants