TouchMenu: keep hamburger menu on the right #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
force-pushed
the
hamburger_right
branch
2 times, most recently
from
d1cbbb0
to
254f21d
Compare
houqp
requested changes
Mar 27, 2017
frontend/ui/widget/touchmenu.lua
Outdated
| local current_icon = i == k - 1 or i == k | ||
| self.icon_seps[i].style = current_icon and "solid" or "none" | ||
| local current_icon = (i == k - 1 or i == k) and k ~= #self.icons | ||
| local last_icon = i == k and k == #self.icons |
There was a problem hiding this comment.
nitpick to reduce comparisons:
local current_icon, last_icon
if k == #self.icons then
current_icon = false
last_icon = i == k
else
current_icon = i == k - 1 or i == k
last_icon = false
end
frontend/ui/widget/touchmenu.lua
Outdated
| s = icon_sep_width + stretch_width + _start_seg, e = icon_sep_width + stretch_width + _end_seg | ||
| } | ||
| } | ||
| self.icon_seps[i].style = "solid" |
There was a problem hiding this comment.
self.icon_seps[i] can be replaced by sep here? sep.style = current_icon and "solid" or "none" can also be moved into the else block after this if block.
Frenzie
force-pushed
the
hamburger_right
branch
from
254f21d
to
21766c3
Compare
|
@houqp Btw, I updated the PR a couple of days ago already. :-) I don't know if GitHub notifies about force pushing. |
houqp
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time without obvious issues. Also see #2572.