Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputContainer: add cancel_text and ok_text #2733

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 7, 2017

Makes it easier to comply with UX style.

  • Change "OK" to "Search dictionary" in Dictionary lookup to comply with UX style
  • Change "OK" to "Search all text" in Fulltext search to comply with UX style

Tacked on but highly related:

  • change "OK" to "Search Wikipedia" in Wikipedia lookup to comply with UX style
  • change "OK" to "Set default" in ConfigDialog to comply with UX style

Chore:

  • fixed up order of requires

@Frenzie Frenzie added the UX label Apr 7, 2017
@Frenzie Frenzie changed the title InputDialog: add cancel_text and ok_text InputContainer: add cancel_text and ok_text Apr 7, 2017
Makes it easier to comply with UX style.

* Change "OK" to "Search dictionary" in Dictionary lookup to comply with UX style
* Change "OK" to "Search all text" in Fulltext search to comply with UX style

Tacked on but highly related:

* change "OK" to "Search Wikipedia" in Wikipedia lookup to comply with UX style
* change "OK" to "Set default" in ConfigDialog to comply with UX style

Chore:

* fixed up order of requires
@houqp houqp merged commit e872188 into koreader:master Apr 8, 2017
@Frenzie Frenzie deleted the lang_dic_default branch October 1, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants