Screensaver option on Kindle devices #2734
Conversation
| @@ -152,6 +152,20 @@ function FileManagerMenu:setUpdateItemTable() | |||
| }, | |||
| } | |||
| } | |||
| elseif Device.isKindle() then | |||
There was a problem hiding this comment.
Does the folder screensaver functionality not work on Kindle? Maybe I'm missing something, but couldn't you just change if Device.isKobo() then to if Device.isKobo() or Device.isKindle() then and add an extra menu item there? In fact Kobo also needs a way to disable screensaver globally besides just for a specific book.
There was a problem hiding this comment.
I have not tested folder screensaver functoinality. Bessides there is no option to disable screensaver globally in Kobo.
Maybe in future I will "fix it".
There was a problem hiding this comment.
You don't have to add anything Kobo-specific, but my point is that you're currently locking Kindle users out of the regular screensaver functionality. Rather, you'd be adding the Kindle-specific "Enable screensaver" option to the menu so that Kindle users can then also choose to disable a specific cover for screensaver and to use a folder (if applicable). Maybe I'm being a bit unclear as I'm slightly distracted? :-)
Edit: Hm, I just realized there are a lot of weird things going on in the screensaver menu. A good candidate for some refactoring I suppose.
| text = _("Screensaver"), | ||
| sub_item_table = { | ||
| { | ||
| text = _("Enable cover screensaver"), |
There was a problem hiding this comment.
I'd change this to "Enable screensaver".
|
I recall there is reason why screen saver was disabled on kindle back then. The MR dev community doesn't want people to use jailbreaking as a mean to circumvent ads in kindles with special offers. @NiLuJe is it still the case today? |
|
Pretty much, yeah.
…On Apr 10, 2017 7:52 AM, "Qingping Hou" ***@***.***> wrote:
I recall there is reason why screen saver is is disabled on kindle back
then. The MR dev community doesn't want people to use jailbreaking as a
mean to circumvent ads in kindles with special offers. @NiLuJe
<https://github.com/NiLuJe> is it still the case today?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2734 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG1ZsE4ixXL4czVdxm3w5YPCH6YRS5Cks5rucO4gaJpZM4M3NGG>
.
|
|
So we should remove screensaver option from Kindle :( |
|
Worst case, it's pretty trivial to check if a device is a SO device, if you
really care about the feature for non SO users.
A simple lipc call should do the trick, IIRC.
On Apr 10, 2017 6:04 PM, "Robert" <notifications@github.com> wrote:
So we should remove screensaver option from Kindle :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2734 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAG1ZuDIxAIDc87gCJfFlmPFhf84pp0kks5rulMDgaJpZM4M3NGG>
.
|
|
OK, I have sent a PR to remove the feature for now. @robert00s I will be more than happy to merge a new PR if this feature is implemented to be only enabled for non SO users. |
Add screensaver on Kindle devices.
Defaults screensaver is disabled. We can enable it by select Menu -> Screensaver -> Enable cover screensaver
Tested on KPW3 with special offers and KPW2.