Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaderFooter (lang): "Show toc markers" to "Show chapter markers" #2735

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 7, 2017

I think it sounds more natural as chapter than as table of content, which is an implementation detail (i.e., the chapter markers are shown based on what's in the TOC).

Also removed redundant "this" from "Remaining pages in this chapter"

@Frenzie Frenzie added the UX label Apr 7, 2017
I think it sounds more natural as chapter than as table of content, which is an implementation detail (i.e., the chapter markers are shown based on what's in the TOC).

Also removed redundant "this" from "Remaining pages in this chapter"
@houqp houqp merged commit 92b9139 into koreader:master Apr 8, 2017
@Frenzie Frenzie deleted the lang_chapter_markers branch October 1, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants