Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Rendering Style, and Comments #3165

Merged
merged 2 commits into from Sep 13, 2017
Merged

Conversation

comradekingu
Copy link
Contributor

@Frenzie
Copy link
Member

Frenzie commented Sep 3, 2017

The comment was referring to the Italian translation cambia modalità di rendering.

it_IT
First letter should be uppercase
by slow_mo, 2 months ago

Screenshot of 'Set render style' in menu context

Regarding the phrase itself, I have no trouble with render style vs. rendering style (cf., Microsoft, 2, 3, 4; pCon.planner). However, I would just get rid of the useless render(ing).

Could you please change the phrase to simply Set style?

@Frenzie Frenzie added the UX label Sep 3, 2017
@comradekingu
Copy link
Contributor Author

@Frenzie Ok, in line with why that makes sense:
Style:
Highlighting:
Floating punctuation:
Font:
Hyphenation:
?

@Frenzie
Copy link
Member

Frenzie commented Sep 3, 2017

Go for it. :-)

@Frenzie
Copy link
Member

Frenzie commented Sep 8, 2017

@comradekingu Is there anything you need assistance with? I'd like to include your proposed changes.

@Frenzie Frenzie merged commit 3f24514 into koreader:master Sep 13, 2017
Frenzie added a commit to Frenzie/koreader that referenced this pull request Sep 13, 2017
Frenzie added a commit that referenced this pull request Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants