[fix] Add current location to location stack from follow link popup #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
force-pushed
the
fix_location_stack
branch
from
406441c
to
c7d526a
Compare
|
I think you mean @poire-z :) |
|
:) (Confirmed the first issue is solved.) |
* Add current location to location stack from follow link popup See koreader#3190 (comment) * Word highlight not removed * "Follow Link" not translated * Typo in docs
Frenzie
force-pushed
the
fix_location_stack
branch
from
c7d526a
to
5186af9
Compare
|
Oups, just noticed there's another one that need similar treatment: to be replaced with: self:onClose()
|
Frenzie
added a commit
that referenced
this pull request
Sep 10, 2017
|
Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3190 (comment)
@robert00s Does this also solve the other issue you noticed?