New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlBoxWidget: fix selection when starting from end #3632

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
3 participants
@poire-z
Contributor

poire-z commented Jan 27, 2018

When selecting multiple words on the HtmlBoxWidget, and selecting backwards (ie: beginning the hold on the last word of the text we want to select - moving till the beginning of the text we want to select), we were getting the text from the first hold till end of page.

@KenMaltby

This comment has been minimized.

KenMaltby commented Jan 27, 2018

I guess this is a slight LTR bias, I can see where it might be a real issue for those that use a RTL script.

oops, fixed above comment, had the directions backwards.

@Frenzie Frenzie merged commit b16c93b into koreader:master Jan 27, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie added the bug label Jan 27, 2018

@Frenzie

This comment has been minimized.

Member

Frenzie commented Jan 27, 2018

Thanks. That might explain some odd behavior I've seen once or twice but didn't realize it wasn't my fault.

@poire-z poire-z deleted the poire-z:html_select_last2first branch Jan 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment