HtmlBoxWidget: fix selection when starting from end #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is a slight LTR bias, I can see where it might be a real issue for those that use a RTL script. oops, fixed above comment, had the directions backwards. |
|
Thanks. That might explain some odd behavior I've seen once or twice but didn't realize it wasn't my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting multiple words on the HtmlBoxWidget, and selecting backwards (ie: beginning the hold on the last word of the text we want to select - moving till the beginning of the text we want to select), we were getting the text from the first hold till end of page.