Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A round of Kobo specific script cleanup #3876

Merged
merged 8 commits into from Apr 15, 2018
Merged

A round of Kobo specific script cleanup #3876

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72ae67e
Start a pass of Kobo script cleanups
NiLuJe Apr 14, 2018
1fa90d8
Flag those scripts as executable in git
NiLuJe Apr 14, 2018
5d5119c
Cleanup Kobo startup script
NiLuJe Apr 14, 2018
a65d4b0
Slimmed down the nickel restart script.
NiLuJe Apr 14, 2018
f661355
Shamelessly steal those bit from Plato
NiLuJe Apr 14, 2018
86933b8
Update Kobo install instrcutions.
NiLuJe Apr 14, 2018
4e9834c
Shellcheck spanked me.
NiLuJe Apr 14, 2018
b12a1d7
Reword README a bit
NiLuJe Apr 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions platform/kobo/nickel.sh
View file
Open in desktop
Expand Up @@ -16,8 +16,8 @@ export LD_LIBRARY_PATH="/usr/local/Kobo"
# NOTE: That check is possibly wrong on PLATFORM == freescale (because I don't know if the sdio_wifi_pwr module exists there), but we don't terribly care about that.
if lsmod | grep -q sdio_wifi_pwr; then
killall udhcpc default.script wpa_supplicant 2>/dev/null
[ "${WIFI_MODULE}" != "8189fs" ] && wlarm_le -i ${INTERFACE} down
ifconfig ${INTERFACE} down
[ "${WIFI_MODULE}" != "8189fs" ] && wlarm_le -i "${INTERFACE}" down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure, quote the non-var but forget the vars. ShellCheck was right! ;-D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I'm usually a bit OCD about unbalanced quoting in tests :D.

ifconfig "${INTERFACE}" down
# NOTE: Kobo's busybox build is weird. rmmod appears to be modprobe in disguise, defaulting to the -r flag. If re-specifying -r starts to fail one day, switch to rmmod without args, or modprobe -r.
rmmod -r "${WIFI_MODULE}"
# c.f., #2394?
Expand Down