[Feature] Support DjVu metadata #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I've been meaning to look into this but never got around to it! I'll have some time to review it tonight. |
Frenzie
reviewed
Nov 9, 2018
Frenzie
pushed a commit
to koreader/koreader-base
that referenced
this pull request
Nov 9, 2018
This implements the getMetadata() function for DjVu documents, following in the style of the same for the PDF implementation. This just dumbly copies all the metadata key-value pairs into a lua table. The intent is to give the frontend everything we possibly can and let it figure out what to do with the info, an example of which can be found in the companion pull request koreader/koreader#4314.
xelxebar
force-pushed
the
feature/djvu-props
branch
from
2b74203
to
d5c5844
Compare
|
Is there something left to do in this PR? This is really cool feature to have. And BTW how often nightly builds are triggered? |
|
Yes, base still needs to be bumped. So it'll actually work. :-) Nightlies are triggered every day around 6 CET. |
|
@Frenzie Thanks for merging base. This PR should be all working now! |
It has been (a few minutes after you merged base PR). |
|
You guys work quick! Thanks! |
|
Thanks for caring about DjVu! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As of f71627c, DjVu support for metadata is faked by setting the document tite to the file's basename. This is fixes that. It is the frontend companion to koreader/koreader-base#753, as such the continuous integration will inevitably fail until base integrates those changes.
If there's a better protocol for this kind of split pull request, please let me know.
Notes
This is my first foray into koreader's codebase as well as lua programming, so please forgive any boneheadeness. I tried to model the
DjvuDocument:getProps()method after its namesake infrontend/document/pdfdocument.lua.The silliness with capitalized keys versus lowercase, as mentioned in the code comment, comes from the covention mentioned in djvused(1). I considered
lower()ing allpropskeys into a new table, but I figured that, with just six keys, it's best to be explicit about the identifications.Anyway, if I've made obvious mistakes or there is a better way to do things, please let me know. I hope this turns out to be useful.