Add Prev/Next page actions to GestureManager #4570
Conversation
|
Also changed the internal action names, because PgUp generally goes backwards on a keyboard ;). |
| self:pageUpdate(10) | ||
| elseif action == "page_update_down10" then | ||
| elseif action == "page_jmp_fwd_1" then | ||
| self:pageUpdate(1) |
There was a problem hiding this comment.
On EPUB this works as expected (at least in page-separated mode) but on PDF/DjVu this specific command definitely isn't the right one. It's supposed to move the display by a screen length, not to literally go to the next page in the document.
There was a problem hiding this comment.
koreader/frontend/apps/reader/modules/readerrolling.lua
Lines 393 to 401 in 8189945
There was a problem hiding this comment.
Stupid idea: send a "TapForward" event instead?
There was a problem hiding this comment.
Doesn't sound that stupid. ReaderPaging also does one that' called "Rel", just a different one.
function ReaderPaging:onTapForward()
self:onPagingRel(1)
return true
end
function ReaderPaging:onTapBackward()
self:onPagingRel(-1)
return true
end
Otherwise you can get rather unexpected results in paged media and scroll mode. Workaround suggested by @NiLuJe here: koreader#4570 (comment)
Otherwise you can get rather unexpected results in paged media and scroll mode. Workaround suggested by @NiLuJe here: koreader#4570 (comment)
Otherwise you can get rather unexpected results in paged media and scroll mode. Workaround suggested by @NiLuJe here: #4570 (comment)
…er#4658) Otherwise you can get rather unexpected results in paged media and scroll mode. Workaround suggested by @NiLuJe here: koreader#4570 (comment)
c.f., https://www.mobileread.com/forums/showthread.php?t=315023