Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prev/Next page actions to GestureManager #4570

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Feb 9, 2019

Also changed the internal action names, because PgUp generally goes backwards on a keyboard ;).

@Frenzie

Frenzie approved these changes Feb 9, 2019

@Frenzie Frenzie merged commit 5eb4fc5 into koreader:master Feb 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie added the UX label Feb 9, 2019

self:pageUpdate(10)
elseif action == "page_update_down10" then
elseif action == "page_jmp_fwd_1" then
self:pageUpdate(1)

This comment has been minimized.

@Frenzie

Frenzie Feb 20, 2019

Member

On EPUB this works as expected (at least in page-separated mode) but on PDF/DjVu this specific command definitely isn't the right one. It's supposed to move the display by a screen length, not to literally go to the next page in the document.

This comment has been minimized.

@Frenzie

Frenzie Feb 20, 2019

Member

function ReaderRolling:onTapForward()
self:onGotoViewRel(1)
return true
end
function ReaderRolling:onTapBackward()
self:onGotoViewRel(-1)
return true
end

This comment has been minimized.

@NiLuJe

NiLuJe Feb 20, 2019

Author Member

Stupid idea: send a "TapForward" event instead?

This comment has been minimized.

@Frenzie

Frenzie Feb 20, 2019

Member

Doesn't sound that stupid. ReaderPaging also does one that' called "Rel", just a different one.

function ReaderPaging:onTapForward()
    self:onPagingRel(1)
    return true
end

function ReaderPaging:onTapBackward()
    self:onPagingRel(-1)
    return true
end

Frenzie added a commit to Frenzie/koreader that referenced this pull request Feb 24, 2019

[fix] Gesture manager: send TapForward event for page forward
Otherwise you can get rather unexpected results in paged media and scroll mode.

Workaround suggested by @NiLuJe here: koreader#4570 (comment)

Frenzie added a commit to Frenzie/koreader that referenced this pull request Feb 24, 2019

[fix] Gesture manager: send TapForward event for page forward
Otherwise you can get rather unexpected results in paged media and scroll mode.

Workaround suggested by @NiLuJe here: koreader#4570 (comment)

Frenzie added a commit that referenced this pull request Feb 24, 2019

[fix] Gesture manager: send TapForward event for page forward (#4658)
Otherwise you can get rather unexpected results in paged media and scroll mode.

Workaround suggested by @NiLuJe here: #4570 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.